-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multi chain token detection polling #28258
Draft
salimtb
wants to merge
52
commits into
develop
Choose a base branch
from
salim/multi-chain-token-detection-polling
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+303
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask-extension into brian/asset-controller-39
… brian/currency-rate-multichain-polling2
…MetaMask/metamask-extension into brian/multiexchangerate
… brian/multiexchangerate
…k-extension into brian/multiexchangerate
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
salimtb
changed the title
Salim/multi chain token detection polling
feat: multi chain token detection polling
Nov 4, 2024
salimtb
force-pushed
the
salim/multi-chain-token-detection-polling
branch
2 times, most recently
from
November 4, 2024 10:37
054b356
to
f13990b
Compare
salimtb
force-pushed
the
salim/multi-chain-token-detection-polling
branch
2 times, most recently
from
November 4, 2024 10:41
d589fee
to
75b0332
Compare
salimtb
commented
Nov 4, 2024
ui/pages/index.js
Outdated
@@ -53,7 +54,9 @@ class Index extends PureComponent { | |||
<CurrencyRateProvider> | |||
<MetamaskNotificationsProvider> | |||
<TokenRatesProvider> | |||
<Routes /> | |||
<TokenDetectionProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inject detectedTokens
as provider , this will add to our global state the object below:
{ '0x1': { detected token ...} , ....}
salimtb
force-pushed
the
salim/multi-chain-token-detection-polling
branch
from
November 4, 2024 11:00
75b0332
to
7067d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TokenDetectionController is responsible for detecting and keeping an updated list of all tokens across supported chains. This dataset is stored in the detectedTokens state variable within Metamask’s state. After completing this task, token detection will be enhanced by implementing periodic polling across all networks linked to the wallet, resulting in a more comprehensive dataset available to users.
This PR branches off of multiexchangerate branch because it will incorporate the useMultiPolling hook needed to initialize polling loops across chainIds.
For each network added to the wallet, the polling loop will receive the network as a parameter and execute token autodetection for it. Once results are available, they will be stored in detectedTokensAllChains, organized by chainId. This approach enables us to retrieve a comprehensive list of detected tokens across all networks.
This should now be working to test locally. Here's some steps to run this locally with core PR:
yarn build
"@metamask/assets-controllers": "../core/packages/assets-controllers",
Related issues
Fixes: #3431
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2024-11-04.at.11.33.34.mov
Pre-merge author checklist
Pre-merge reviewer checklist