Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Solana shared utilities and constants #28269

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ulissesferreira
Copy link

@ulissesferreira ulissesferreira commented Nov 4, 2024

Description

As we look to simplify snaps ability to support multiple chains we find that some code needs to be included in the main extension to make sure it can be easily imported throughout. In this PR we add utility functions similar to the Bitcoin ones but for Solana.

Open in GitHub Codespaces

Manual testing steps

  1. Run tests and make sure they still pass
  2. Run build process and make sure it succeeds

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ulissesferreira ulissesferreira requested a review from a team as a code owner November 4, 2024 14:57
Copy link
Contributor

github-actions bot commented Nov 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-sol PRs from the Solana snap team label Nov 4, 2024
@ulissesferreira ulissesferreira marked this pull request as draft November 4, 2024 14:58
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 4, 2024
@ulissesferreira
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@ulissesferreira ulissesferreira force-pushed the chore/add-solana-utilities branch 3 times, most recently from b24978d to e2b28f1 Compare November 4, 2024 15:13
@zone-live
Copy link
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@ulissesferreira ulissesferreira marked this pull request as ready for review November 5, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-sol PRs from the Solana snap team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants