fix: flaky test Phishing Detection Via Iframe should redirect users to the the MetaMask Phishing Detection page when an iframe domain is on the phishing blocklist

[seaona]

Description

There is a race condition in our Extension e2e tests, where we click the continue to unsafe link before the event listener has been attached. This causes the click to not take any effect and the test fail sometimes.

Here is an example of the failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/103699/workflows/b2ef7c35-f54a-4ea8-bd8b-15e57585d6fe/jobs/3865722/artifacts

See how after clicking the anchor element, the redirect never happens, because the click was done before the event listener was added.

The fix has been done in the phishing page level, where I added a new test id once the event listener click has been added, so we can now wait for that selector id to be in the page, before clicking.

Related issues

Fixes: #27661

Manual testing steps

1. Check ci

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [0591461]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1990 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	283	2318	1897	394	189
		domContentLoaded	1720	2261	1955	129	62
		load	1769	2325	1990	137	66
		domInteractive	27	100	53	19	9
		backgroundConnect	9	98	37	26	12
		firstReactRender	84	217	112	28	13
		getState	5	71	24	22	11
		initialActions	0	1	0	0	0
		loadScripts	1269	1730	1432	119	57
		setupStore	10	91	23	20	10
		uiStartup	1937	2683	2230	182	88

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[chloeYue]

LGTM