Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ApeChain network and token icons #11928

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Conversation

gambinish
Copy link
Contributor

Description

Mobile version of: MetaMask/metamask-extension#27974

Related issues

Manual testing steps

Add ApeChain custom network, with APE symbol. Native token should be token icon, network icons should be APE network icon.

Screenshots/Recordings

Screenshot 2024-10-21 at 12 26 38 PM Screenshot 2024-10-21 at 12 26 43 PM Screenshot 2024-10-21 at 12 26 53 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri
Copy link
Contributor

Hey @gambinish , can we undraft this one? Were you planning to add something else to it?

@gambinish gambinish marked this pull request as ready for review October 28, 2024 15:32
@gambinish gambinish requested a review from a team as a code owner October 28, 2024 15:32
@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c968940
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be0b2049-9e39-4c77-9296-b75d6846ee64

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.48%. Comparing base (ead35c4) to head (0ea8e7a).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11928      +/-   ##
==========================================
+ Coverage   55.35%   55.48%   +0.13%     
==========================================
  Files        1767     1772       +5     
  Lines       39841    39931      +90     
  Branches     4965     4974       +9     
==========================================
+ Hits        22052    22157     +105     
+ Misses      16274    16258      -16     
- Partials     1515     1516       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 30, 2024

@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit b4567ce Oct 30, 2024
37 checks passed
@sahar-fehri sahar-fehri deleted the feat/add-ape-icon branch October 30, 2024 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants