Do not update parentCollection if the child object has not been modified #23
+22
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also updated the tests so they can be started with latest version of Meteor |
|
ping @StorytellerCZ , I just fixed conflicts and verified tests :) |
|
We'll have to figure out what is going on with the tests here. |
also removing all browser tests since this package is server code only
|
I fixed the github CI tests in my last commit. Here is the link of the run in my repo |
|
@vparpoil so it looks like we have to drop support form Meteor 1? |
|
I indeed dropped the testing with Meteor 1. Since v2 was published in January 2021, I don't see the benefits of keeping those tests. What would be the arguments in favor of keeping tests for Meteor 1 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #22