Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dictionary.rs #24

Closed
wants to merge 1 commit into from
Closed

Conversation

alexkingnz
Copy link

Allow tabs as well as spaces in dictionary files.

E.g. the /etc/radcli/dictionary in libradcli4 package on debian, which I intend to use, uses tabs. Without this change, the client claims not to know about the "User-Name" ATTRIBUTE. With it, things work fine.

Thanks,
Alex

Allow tabs as well as spaces in dictionary files
@MikhailMS
Copy link
Owner

Hello there @alexkingnz - thank you for your PR

Looks simple and could be merged straighaway, just one thing - would appreciate if you can change PR from master to development branch - I don't allow any changes to be made directly to master branch :)

Then I can review it together with the next things awaiting to get fixed on developemnt branch and prepare new release by the end of this week (or you can build directly from development until I deploy library to crates.io)

@MikhailMS
Copy link
Owner

It is now part of development branch and would be published as part of new release soon :)

@MikhailMS MikhailMS closed this Jul 31, 2022
MikhailMS added a commit that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants