Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add ctx options for remark plugins #1085

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

Saul-Mirone
Copy link
Member

βœ… Closes: #1064

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Add ctx options for remark plugins created by $remark.

import { $remark } from '@milkdown/utils';

// Create remark plugin with options
const myRemarkPlugin = $remark('myRemarkPlugin', (ctx) => (options) => plugin);

Editor.make()
  .config(ctx => {
    // set value for options
    ctx.set(myRemarkPlugin.options.key, {
      // some options
    });
  })
  .use(myRemarkPlugin);

How did you test this change?

E2E

@nx-cloud
Copy link

nx-cloud bot commented Aug 12, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6554ebd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this branch


βœ… Successfully ran 3 targets

Sent with πŸ’Œ from NxCloud.

@cypress
Copy link

cypress bot commented Aug 12, 2023

Passing run #466 β†—οΈŽ

0 71 0 0 Flakiness 0

Details:

Merge 6554ebd into d42040f...
Project: Default Project Commit: c0349da338 ℹ️
Status: Passed Duration: 01:49 πŸ’‘
Started: Aug 12, 2023 8:20 AM Ended: Aug 12, 2023 8:22 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Saul-Mirone Saul-Mirone merged commit 24ad8f8 into main Aug 12, 2023
10 checks passed
@Saul-Mirone Saul-Mirone deleted the remark-options-ctx branch August 12, 2023 08:29
@github-actions github-actions bot mentioned this pull request Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add configuration for remark-gfm
1 participant