Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ› missing type error in theme-nord #1095

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

Saul-Mirone
Copy link
Member

βœ… Closes: #1075

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Fix the issue that import theme-nord will throw error in typescript.

How did you test this change?

Manully

@nx-cloud
Copy link

nx-cloud bot commented Aug 20, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7527f89. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this branch


βœ… Successfully ran 3 targets

Sent with πŸ’Œ from NxCloud.

@Saul-Mirone Saul-Mirone enabled auto-merge (squash) August 20, 2023 12:40
@cypress
Copy link

cypress bot commented Aug 20, 2023

Passing run #482 β†—οΈŽ

0 75 0 0 Flakiness 0

Details:

Merge 7527f89 into 44445a6...
Project: Default Project Commit: 53d6414206 ℹ️
Status: Passed Duration: 02:06 πŸ’‘
Started: Aug 20, 2023 12:40 PM Ended: Aug 20, 2023 12:42 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Saul-Mirone Saul-Mirone merged commit 32781d1 into main Aug 20, 2023
10 checks passed
@Saul-Mirone Saul-Mirone deleted the fix-nord-types branch August 20, 2023 12:46
@github-actions github-actions bot mentioned this pull request Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] With patch: Bundler issue with Vite for @milkdown/theme-nord
1 participant