Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: print lint warnings with github-compatible format #1507

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Sep 10, 2024

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

When oxlint gets run in CI, lint warnings will be printed with a format that allows Github to display them as annotations on your PR. Thanks for using Oxlint <3

How did you test this change?

N/A

## What This PR Does

When `oxlint` gets run in CI, lint warnings will be printed with a format that allows github to display them as annotations on your PR. Thanks for using Oxlint <3
Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: e109426

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 3:39am

Copy link
Member

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't know you have this feature!

Copy link

nx-cloud bot commented Sep 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e109426. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Saul-Mirone Saul-Mirone merged commit aefa245 into Milkdown:main Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants