Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when attempting to connect to board via serial #1781

Merged
merged 9 commits into from
Jun 16, 2024

Conversation

neilenns
Copy link
Contributor

@neilenns neilenns commented May 25, 2024

Fixes #1778

  • Properly catch empty COM port values when scanning for devices (use String.IsNullOrEmpty() instead of a null test)
  • Log an error if the COM port value isn't available in the device name
  • Wrap the serial port connection code in a try/catch block

Copy link

Build for this pull request:
MobiFlightConnector.zip

Copy link

Build for this pull request:
MobiFlightConnector.zip

@neilenns
Copy link
Contributor Author

The specific devices is getting connected with an empty COM port name for some reason.

Copy link

Build for this pull request:
MobiFlightConnector.zip

Copy link

Build for this pull request:
MobiFlightConnector.zip

Copy link

Build for this pull request:
MobiFlightConnector.zip

Copy link

Build for this pull request:
MobiFlightConnector.zip

@neilenns neilenns marked this pull request as ready for review May 27, 2024 23:19
@neilenns neilenns requested a review from DocMoebiuz as a code owner May 27, 2024 23:19
Copy link

Build for this pull request:
MobiFlightConnector.zip

@DocMoebiuz DocMoebiuz merged commit 51be925 into MobiFlight:main Jun 16, 2024
1 check passed
@DocMoebiuz DocMoebiuz added the bug Something isn't working in a officially released version label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in a officially released version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when attempting to connect to board via serial
2 participants