InvalidCharacterNotice changes based on requirement

MobilityData · Oct 16, 2024 · 2a2628f · 2a2628f
1 parent 5d32118
commit 2a2628f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/...dator/notice/InvalidCharactersNotice.java → ...idator/notice/InvalidCharacterNotice.java b/...dator/notice/InvalidCharactersNotice.java → ...idator/notice/InvalidCharacterNotice.java
@@ -5,13 +5,12 @@
 import org.mobilitydata.gtfsvalidator.annotation.GtfsValidationNotice;
 
 /**
- * This field contains invalid characters such as the replacement character ("\uFFFD").
+ * This field contains invalid characters, such as the replacement character ("\uFFFD").
  *
- * <p>Fields with customer-facing text should not contain invalid characters to ensure good
- * readability and accessibility.
+ * <p>Check that text was properly encoded in UTF-8 as required by GTFS.
  */
 @GtfsValidationNotice(severity = ERROR)
-public class InvalidCharactersNotice extends ValidationNotice {
+public class InvalidCharacterNotice extends ValidationNotice {
   /** The name of the file containing the invalid characters. */
   private final String filename;
 
@@ -24,7 +23,7 @@ public class InvalidCharactersNotice extends ValidationNotice {
   /** The value of the field containing the invalid characters. */
   private final String fieldValue;
 
-  public InvalidCharactersNotice(
+  public InvalidCharacterNotice(
       String filename, long csvRowNumber, String fieldName, String fieldValue) {
     this.filename = filename;
     this.csvRowNumber = csvRowNumber;

diff --git a/core/src/main/java/org/mobilitydata/gtfsvalidator/parsing/RowParser.java b/core/src/main/java/org/mobilitydata/gtfsvalidator/parsing/RowParser.java
@@ -124,8 +124,7 @@ public String asString(int columnIndex, GtfsColumnDescriptor columnDescriptor) {
       // Validate if the string contains invalid characters
       if (containsInvalidCharacters(s)) {
         noticeContainer.addValidationNotice(
-            new InvalidCharactersNotice(
-                fileName, getRowNumber(), columnDescriptor.columnName(), s));
+            new InvalidCharacterNotice(fileName, getRowNumber(), columnDescriptor.columnName(), s));
       }
 
       s =