Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bump validation workflows to use large machine instances #1320

Merged
merged 5 commits into from
Jan 31, 2023
Merged

fix: Bump validation workflows to use large machine instances #1320

merged 5 commits into from
Jan 31, 2023

Conversation

bdferris-v2
Copy link
Collaborator

We want to avoid running out of heap memory when processing large feeds.

Closes #1304.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1389 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1389 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1389 sources (~0 %) are corrupted.
Commit: e664550
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@fredericsimard fredericsimard merged commit 9a8d610 into master Jan 31, 2023
@fredericsimard fredericsimard deleted the issue/1304/large-feeds branch January 31, 2023 18:53
@bdferris-v2 bdferris-v2 mentioned this pull request Jan 31, 2023
Closed
KClough pushed a commit to JarvusInnovations/gtfs-validator that referenced this pull request Feb 24, 2023
@bdferris-v2 @KClough
fix: Bump validation workflows to use large machine instances (Mobili…
0c588b6 
…tyData#1320)

* Bump validation workflows to use large machine instances to avoid running out of heap memory when processing large feeds.

Closes MobilityData#1304.

* Try using a label instead.

* label => labels

* Try yet another runner syntax.
KClough pushed a commit to JarvusInnovations/gtfs-validator that referenced this pull request Mar 1, 2023
@bdferris-v2 @KClough
fix: Bump validation workflows to use large machine instances (Mobili…
15caa08 
…tyData#1320)

* Bump validation workflows to use large machine instances to avoid running out of heap memory when processing large feeds.

Closes MobilityData#1304.

* Try using a label instead.

* label => labels

* Try yet another runner syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericsimard fredericsimard fredericsimard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub workflow action failures for large feeds
2 participants
@bdferris-v2 @fredericsimard