-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1689 web validator app consumes execution resultsjson #1710
feat: 1689 web validator app consumes execution resultsjson #1710
Conversation
@davidgamez I would like to get your comments before you go on vacation. |
web_cd: | ||
name: Deploy web service | ||
runs-on: ubuntu-latest | ||
|
||
env: | ||
ENV_NAME : stg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any relevant changes to the issue; it's only formatting. Can you revert these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as I hit cmd+s in VSCode, it's reformatted automatically. I'm not sure how to resolve it.
✅ Rule acceptance tests passed. |
I am closing this PR as I had issues after a master rebase. I created a twin PR #1712. |
Summary:
Closes #1689
consumes the results.json file.
Expected behavior:
This code consumes the result.json file.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything