Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1689 web validator app consumes execution resultsjson #1710

Closed

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Mar 12, 2024

Summary:
Closes #1689
consumes the results.json file.

Expected behavior:
This code consumes the result.json file.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Mar 12, 2024 that may be closed by this pull request
2 tasks
@qcdyx qcdyx assigned qcdyx and davidgamez and unassigned qcdyx Mar 12, 2024
@qcdyx
Copy link
Contributor Author

qcdyx commented Mar 12, 2024

@davidgamez I would like to get your comments before you go on vacation.

web_cd:
name: Deploy web service
runs-on: ubuntu-latest

env:
ENV_NAME : stg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any relevant changes to the issue; it's only formatting. Can you revert these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as I hit cmd+s in VSCode, it's reformatted automatically. I'm not sure how to resolve it.

web/client/src/routes/+page.svelte Outdated Show resolved Hide resolved
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: 9eb2bec
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez
Copy link
Member

I am closing this PR as I had issues after a master rebase. I created a twin PR #1712.

@davidgamez davidgamez closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web validator app consumes execution_results.json
3 participants