feat: Do not call validators for missing columns #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpitre
changed the title
…-columns-that-are-not-present
… to generate the shouldCallValidate method
jcpitre
changed the title
davidgamez
reviewed
Oct 10, 2024
core/src/main/java/org/mobilitydata/gtfsvalidator/validator/FileValidator.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/validator/SingleEntityValidator.java
Outdated
Show resolved
Hide resolved
...ain/java/org/mobilitydata/gtfsvalidator/validator/StopTimesGeographyIdPresenceValidator.java
Outdated
Show resolved
Hide resolved
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 79ea9df 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
…-columns-that-are-not-present
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 0a3013c 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit c6cd968 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
davidgamez
approved these changes
Oct 11, 2024
…-columns-that-are-not-present
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit ac6b579 📊 Notices ComparisonNew Errors (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1596 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
jcpitre
deleted the
1839-optimisation-do-not-run-validators-on-columns-that-are-not-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
closes #1839
Added an optional method to establish if a validator should be run.
The idea is to add more as we go along.
The list of not-run validator is printed in the validator output.
Note that if a file is not present in the dataset its related single file validator will appear in the list of not-run validators.
Expected behavior:
For the validators that check if the validation should be done, we expect them not to be run if the conditions are proper, as listed above.
You can use this dataset:
test1839.zip
It has been crafted so these validators are not run:
Note that the list of not-run validators also includes foreign key validators where the whole file is missing.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything