Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarified below threshold language in notices #1886

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

emmambd
Copy link
Contributor

@emmambd emmambd commented Oct 10, 2024

Summary:

We received some user feedback that the trip_distance_exceeds_shape_distance_below_threshold and equal_shape_distance_diff_coordinates_below_threshold notice language was confusing. Added description about the value being greater than 0 but below the threshold to more clearly convey this.

Expected behavior:

Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [X ] Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit d6d4065
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 4.02 4.05 ⬆️+0.03
Median -- 1.40 1.43 ⬆️+0.04
Standard Deviation -- 11.56 11.43 ⬇️-0.14
Minimum in References Reports us-michigan-detroit-people-mover-gtfs-417 0.52 0.61 ⬆️+0.09
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 296.08 292.32 ⬇️-3.77
Minimum in Latest Reports us-california-city-of-wasco-gtfs-1788 0.56 0.51 ⬇️-0.05
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 296.08 292.32 ⬇️-3.77
📜 Memory Consumption

List of 25 datasets(memory has increased).

Dataset ID Snapshot Key(Used Memory) Reference Latest Difference
it-lombardia-agenzia-mobilita-ambiente-territorio-gtfs-1231
GtfsFeedLoader.loadTables 1.69 GiB 1.06 GiB ⬇️-645.13 MiB
GtfsFeedLoader.executeMultiFileValidators 1.76 GiB 988.87 MiB ⬇️-814.64 MiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.76 GiB 988.87 MiB ⬇️-814.64 MiB
ValidationRunner.run 1.62 GiB 1.28 GiB ⬇️-348.64 MiB
gb-argyll-and-bute-west-coast-motors-gtfs-1957
GtfsFeedLoader.loadTables 575.34 MiB 202.00 MiB ⬇️-373.34 MiB
GtfsFeedLoader.executeMultiFileValidators 2.07 GiB 341.55 MiB ⬇️-1.74 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 2.07 GiB 341.55 MiB ⬇️-1.74 GiB
ValidationRunner.run 2.12 GiB 391.71 MiB ⬇️-1.73 GiB
be-vlaams-gewest-de-lijn-gtfs-684
GtfsFeedLoader.loadTables 5.49 GiB 4.89 GiB ⬇️-621.26 MiB
GtfsFeedLoader.executeMultiFileValidators 7.53 GiB 6.55 GiB ⬇️-1005.99 MiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 7.53 GiB 6.55 GiB ⬇️-1005.99 MiB
ValidationRunner.run 7.30 GiB 6.08 GiB ⬇️-1.22 GiB
fr-bretagne-breizhgo-gtfs-1837
GtfsFeedLoader.loadTables 2.08 GiB 1.45 GiB ⬇️-643.51 MiB
GtfsFeedLoader.executeMultiFileValidators 2.18 GiB 1.55 GiB ⬇️-643.51 MiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 2.18 GiB 1.55 GiB ⬇️-643.51 MiB
ValidationRunner.run 2.92 GiB 2.29 GiB ⬇️-641.51 MiB
us-massachusetts-massachusetts-ferry-service-gtfs-1309
GtfsFeedLoader.loadTables 154.06 MiB 154.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 158.06 MiB 158.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 158.06 MiB 158.06 MiB -
ValidationRunner.run 159.98 MiB 159.98 MiB -
au-queensland-sunbus-townsville-gtfs-677
GtfsFeedLoader.loadTables 228.06 MiB 228.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 384.06 MiB 384.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 384.06 MiB 384.06 MiB -
ValidationRunner.run 397.87 MiB 397.87 MiB -
fr-hauts-de-france-region-hauts-de-france-gtfs-789
GtfsFeedLoader.loadTables 240.17 MiB 240.17 MiB -
GtfsFeedLoader.executeMultiFileValidators 254.06 MiB 254.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 254.06 MiB 254.06 MiB -
ValidationRunner.run 267.97 MiB 267.97 MiB -
us-california-downeylink-gtfs-383
GtfsFeedLoader.loadTables 192.06 MiB 192.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 224.06 MiB 224.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 224.06 MiB 224.06 MiB -
ValidationRunner.run 225.97 MiB 225.97 MiB -
us-california-lake-transit-authority-lta-gtfs-68
GtfsFeedLoader.loadTables 286.05 MiB 286.05 MiB -
GtfsFeedLoader.executeMultiFileValidators 388.06 MiB 388.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 388.06 MiB 388.06 MiB -
ValidationRunner.run 390.05 MiB 390.05 MiB -
us-washington-clallam-transit-system-gtfs-279
GtfsFeedLoader.loadTables 193.94 MiB 193.94 MiB -
GtfsFeedLoader.executeMultiFileValidators 340.00 MiB 340.00 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 340.00 MiB 340.00 MiB -
ValidationRunner.run 342.06 MiB 342.06 MiB -
gb-manchester-go-north-west-gtfs-1936
GtfsFeedLoader.loadTables 58.05 MiB 58.05 MiB -
GtfsFeedLoader.executeMultiFileValidators 58.05 MiB 58.05 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 58.05 MiB 58.05 MiB -
ValidationRunner.run 58.06 MiB 58.06 MiB -
us-colorado-mountain-metropolitan-transit-gtfs-1241
GtfsFeedLoader.loadTables 290.06 MiB 290.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 292.06 MiB 292.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 292.06 MiB 292.06 MiB -
ValidationRunner.run 309.87 MiB 309.87 MiB -
ca-ontario-belleville-transit-gtfs-1858
GtfsFeedLoader.loadTables 205.94 MiB 205.94 MiB -
GtfsFeedLoader.executeMultiFileValidators 240.00 MiB 240.00 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 240.00 MiB 240.00 MiB -
ValidationRunner.run 251.96 MiB 251.96 MiB -
us-oregon-mt-bachelor-gtfs-933
GtfsFeedLoader.loadTables 193.94 MiB 193.94 MiB -
GtfsFeedLoader.executeMultiFileValidators 196.00 MiB 196.00 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 196.00 MiB 196.00 MiB -
ValidationRunner.run 196.00 MiB 196.00 MiB -
us-kentucky-blue-grass-community-action-partnership-gtfs-362
GtfsFeedLoader.loadTables 222.06 MiB 222.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 249.94 MiB 249.94 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 249.94 MiB 249.94 MiB -
ValidationRunner.run 249.94 MiB 249.94 MiB -
us-california-south-county-transit-link-gtfs-817
GtfsFeedLoader.loadTables 230.06 MiB 230.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 240.06 MiB 240.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 240.06 MiB 240.06 MiB -
ValidationRunner.run 241.97 MiB 241.97 MiB -
us-florida-brightline-trains-llc-gtfs-1126
GtfsFeedLoader.loadTables 126.06 MiB 126.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 140.06 MiB 140.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 140.06 MiB 140.06 MiB -
ValidationRunner.run 141.98 MiB 141.98 MiB -
us-california-ventura-county-transportation-commission-gtfs-31
GtfsFeedLoader.loadTables 372.06 MiB 372.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 542.06 MiB 542.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 542.06 MiB 542.06 MiB -
ValidationRunner.run 543.97 MiB 543.97 MiB -
ca-british-columbia-bc-transit-chilliwack-gtfs-699
GtfsFeedLoader.loadTables 194.05 MiB 194.05 MiB -
GtfsFeedLoader.executeMultiFileValidators 242.05 MiB 242.05 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 242.05 MiB 242.05 MiB -
ValidationRunner.run 251.96 MiB 251.96 MiB -
us-ohio-laketran-gtfs-410
GtfsFeedLoader.loadTables 220.06 MiB 220.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 402.06 MiB 402.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 402.06 MiB 402.06 MiB -
ValidationRunner.run 414.06 MiB 414.06 MiB -
us-california-yolo-county-transportation-district-gtfs-1295
GtfsFeedLoader.loadTables 186.06 MiB 186.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 226.06 MiB 226.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 226.06 MiB 226.06 MiB -
ValidationRunner.run 235.97 MiB 235.97 MiB -
us-california-san-leandro-links-gtfs-810
GtfsFeedLoader.loadTables 196.00 MiB 196.00 MiB -
GtfsFeedLoader.executeMultiFileValidators 200.00 MiB 200.00 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 200.00 MiB 200.00 MiB -
ValidationRunner.run 200.00 MiB 200.00 MiB -
us-washington-squaxin-island-transit-gtfs-846
GtfsFeedLoader.loadTables 156.00 MiB 156.00 MiB -
GtfsFeedLoader.executeMultiFileValidators 164.00 MiB 164.00 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 164.00 MiB 164.00 MiB -
ValidationRunner.run 165.92 MiB 165.92 MiB -
us-oregon-city-of-milton-freewater-public-transportation-gtfs-274
GtfsFeedLoader.loadTables 202.06 MiB 202.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 204.06 MiB 204.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 204.06 MiB 204.06 MiB -
ValidationRunner.run 205.97 MiB 205.97 MiB -
us-oregon-blue-star-bus-gtfs-256
GtfsFeedLoader.loadTables 182.06 MiB 182.06 MiB -
GtfsFeedLoader.executeMultiFileValidators 182.06 MiB 182.06 MiB -
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 182.06 MiB 182.06 MiB -
ValidationRunner.run 182.06 MiB 182.06 MiB -

List of 25 datasets(memory has decreased).

Dataset ID Snapshot Key(Used Memory) Reference Latest Difference
pl-pomorskie-zarzad-transportu-miejskiego-gdansk-ztm-gdansk-gtfs-1014
GtfsFeedLoader.loadTables 920.00 MiB 872.00 MiB ⬇️-48.00 MiB
GtfsFeedLoader.executeMultiFileValidators 1.90 GiB 3.06 GiB ⬆️+1.16 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.90 GiB 3.06 GiB ⬆️+1.16 GiB
ValidationRunner.run 2.75 GiB 3.91 GiB ⬆️+1.16 GiB
fr-centre-val-de-loire-tours-metropole-val-de-loire-gtfs-1987
GtfsFeedLoader.loadTables 371.54 MiB 371.30 MiB ⬇️-253.73 KiB
GtfsFeedLoader.executeMultiFileValidators 1.43 GiB 1.42 GiB ⬇️-4.25 MiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.43 GiB 1.42 GiB ⬇️-4.25 MiB
ValidationRunner.run 435.06 MiB 1.77 GiB ⬆️+1.35 GiB
co-distrito-capital-de-bogota-simur-bogota-gtfs-2012
GtfsFeedLoader.loadTables 2.02 GiB 1.96 GiB ⬇️-68.00 MiB
GtfsFeedLoader.executeMultiFileValidators 6.04 GiB 2.43 GiB ⬇️-3.60 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 6.04 GiB 2.43 GiB ⬇️-3.60 GiB
ValidationRunner.run 5.14 GiB 6.53 GiB ⬆️+1.38 GiB
au-western-australia-transperth-gtfs-1169
GtfsFeedLoader.loadTables 1014.79 MiB 1021.55 MiB ⬆️+6.77 MiB
GtfsFeedLoader.executeMultiFileValidators 917.38 MiB 2.40 GiB ⬆️+1.50 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 917.38 MiB 2.40 GiB ⬆️+1.50 GiB
ValidationRunner.run 1.38 GiB 2.88 GiB ⬆️+1.50 GiB
gb-unknown-go-north-east-gtfs-1935
GtfsFeedLoader.loadTables 386.51 MiB 393.32 MiB ⬆️+6.81 MiB
GtfsFeedLoader.executeMultiFileValidators 5.28 GiB 1.95 GiB ⬇️-3.33 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 5.28 GiB 1.95 GiB ⬇️-3.33 GiB
ValidationRunner.run 640.14 MiB 2.20 GiB ⬆️+1.57 GiB
ar-buenos-aires-colectivos-buenos-aires-gtfs-1220
GtfsFeedLoader.loadTables 6.01 GiB 5.38 GiB ⬇️-646.96 MiB
GtfsFeedLoader.executeMultiFileValidators 5.15 GiB 5.13 GiB ⬇️-22.82 MiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 5.15 GiB 5.13 GiB ⬇️-22.82 MiB
ValidationRunner.run 5.45 GiB 7.07 GiB ⬆️+1.62 GiB
fr-hauts-de-france-reseau-de-transport-transpole-de-la-metropole-europeenne-de-lille-gtfs-1201
GtfsFeedLoader.loadTables 814.09 MiB 1.34 GiB ⬆️+562.82 MiB
GtfsFeedLoader.executeMultiFileValidators 1.12 GiB 1.67 GiB ⬆️+564.82 MiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.12 GiB 1.67 GiB ⬆️+564.82 MiB
ValidationRunner.run 502.06 MiB 2.16 GiB ⬆️+1.67 GiB
es-canarias-transportes-interurbanos-de-tenerife-titsa-gtfs-787
GtfsFeedLoader.loadTables 572.95 MiB 566.95 MiB ⬇️-6.00 MiB
GtfsFeedLoader.executeMultiFileValidators 2.28 GiB 2.25 GiB ⬇️-26.04 MiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 2.28 GiB 2.25 GiB ⬇️-26.04 MiB
ValidationRunner.run 977.75 MiB 2.74 GiB ⬆️+1.79 GiB
il-unknown-ministry-of-transport-and-road-safety-gtfs-1134
GtfsFeedLoader.loadTables 3.34 GiB 3.02 GiB ⬇️-323.65 MiB
GtfsFeedLoader.executeMultiFileValidators 6.23 GiB 8.33 GiB ⬆️+2.10 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 6.23 GiB 8.33 GiB ⬆️+2.10 GiB
ValidationRunner.run 8.71 GiB 4.84 GiB ⬇️-3.86 GiB
us-illinois-chicago-transit-authority-cta-gtfs-389
GtfsFeedLoader.loadTables 1.42 GiB 1.67 GiB ⬆️+258.00 MiB
GtfsFeedLoader.executeMultiFileValidators 1.56 GiB 3.78 GiB ⬆️+2.22 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.56 GiB 3.78 GiB ⬆️+2.22 GiB
ValidationRunner.run 3.38 GiB 5.61 GiB ⬆️+2.22 GiB
cz-praha-prazska-integrovana-doprava-pid-gtfs-767
GtfsFeedLoader.loadTables 1.27 GiB 1.21 GiB ⬇️-62.84 MiB
GtfsFeedLoader.executeMultiFileValidators 4.81 GiB 3.21 GiB ⬇️-1.60 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 4.81 GiB 3.21 GiB ⬇️-1.60 GiB
ValidationRunner.run 1.53 GiB 3.78 GiB ⬆️+2.25 GiB
de-nordrhein-westfalen-rurtalbahn-gmbh-gtfs-1224
GtfsFeedLoader.loadTables 639.58 MiB 647.81 MiB ⬆️+8.22 MiB
GtfsFeedLoader.executeMultiFileValidators 2.23 GiB 4.49 GiB ⬆️+2.26 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 2.23 GiB 4.49 GiB ⬆️+2.26 GiB
ValidationRunner.run 2.46 GiB 4.71 GiB ⬆️+2.26 GiB
tw-taichung-fengyuan-passenger-transport-gtfs-1083
GtfsFeedLoader.loadTables 1.18 GiB 1.17 GiB ⬇️-11.14 MiB
GtfsFeedLoader.executeMultiFileValidators 1.50 GiB 3.00 GiB ⬆️+1.51 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.50 GiB 3.00 GiB ⬆️+1.51 GiB
ValidationRunner.run 1.64 GiB 4.01 GiB ⬆️+2.37 GiB
hu-budapest-budapesti-kozlekedesi-kozpont-bkk-gtfs-990
GtfsFeedLoader.loadTables 1.50 GiB 1.53 GiB ⬆️+33.99 MiB
GtfsFeedLoader.executeMultiFileValidators 1.80 GiB 3.18 GiB ⬆️+1.38 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.80 GiB 3.18 GiB ⬆️+1.38 GiB
ValidationRunner.run 2.51 GiB 5.11 GiB ⬆️+2.59 GiB
fr-provence-alpes-cote-dazur-palmbus-gtfs-925
GtfsFeedLoader.loadTables 2.81 GiB 2.84 GiB ⬆️+30.43 MiB
GtfsFeedLoader.executeMultiFileValidators 651.99 MiB 3.55 GiB ⬆️+2.91 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 651.99 MiB 3.55 GiB ⬆️+2.91 GiB
ValidationRunner.run 713.99 MiB 3.61 GiB ⬆️+2.91 GiB
it-piemonte-bus-company-srl-gtfs-1194
GtfsFeedLoader.loadTables 496.72 MiB 532.86 MiB ⬆️+36.14 MiB
GtfsFeedLoader.executeMultiFileValidators 1.66 GiB 4.62 GiB ⬆️+2.96 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.66 GiB 4.62 GiB ⬆️+2.96 GiB
ValidationRunner.run 1.69 GiB 4.65 GiB ⬆️+2.96 GiB
de-unknown-fluo-grand-est-67-gtfs-1075
GtfsFeedLoader.loadTables 1.63 GiB 1.49 GiB ⬇️-144.80 MiB
GtfsFeedLoader.executeMultiFileValidators 1.86 GiB 4.98 GiB ⬆️+3.12 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.86 GiB 4.98 GiB ⬆️+3.12 GiB
ValidationRunner.run 2.01 GiB 5.13 GiB ⬆️+3.13 GiB
be-unknown-societe-regionale-wallonne-du-transport-gtfs-1212
GtfsFeedLoader.loadTables 2.55 GiB 2.18 GiB ⬇️-380.00 MiB
GtfsFeedLoader.executeMultiFileValidators 3.50 GiB 6.88 GiB ⬆️+3.38 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 3.50 GiB 6.88 GiB ⬆️+3.38 GiB
ValidationRunner.run 6.58 GiB 4.36 GiB ⬇️-2.21 GiB
fi-varsinais-suomi-turku-gtfs-864
GtfsFeedLoader.loadTables 567.51 MiB 537.25 MiB ⬇️-30.27 MiB
GtfsFeedLoader.executeMultiFileValidators 867.73 MiB 4.34 GiB ⬆️+3.49 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 867.73 MiB 4.34 GiB ⬆️+3.49 GiB
ValidationRunner.run 1.03 GiB 4.52 GiB ⬆️+3.49 GiB
ca-ontario-hamilton-street-railway-gtfs-723
GtfsFeedLoader.loadTables 816.00 MiB 2.76 GiB ⬆️+1.96 GiB
GtfsFeedLoader.executeMultiFileValidators 762.95 MiB 4.33 GiB ⬆️+3.58 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 762.95 MiB 4.33 GiB ⬆️+3.58 GiB
ValidationRunner.run 1.18 GiB 4.77 GiB ⬆️+3.59 GiB
de-baden-wurttemberg-stadtwerke-heilbronn-swhn-gtfs-783
GtfsFeedLoader.loadTables 1.27 GiB 1.13 GiB ⬇️-146.04 MiB
GtfsFeedLoader.executeMultiFileValidators 1.45 GiB 5.49 GiB ⬆️+4.04 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.45 GiB 5.49 GiB ⬆️+4.04 GiB
ValidationRunner.run 1.55 GiB 5.59 GiB ⬆️+4.04 GiB
ru-sankt-peterburg-peterburgskii-metropoliten-petersburg-metro-gtfs-1186
GtfsFeedLoader.loadTables 976.46 MiB 1.04 GiB ⬆️+84.89 MiB
GtfsFeedLoader.executeMultiFileValidators 1.59 GiB 3.52 GiB ⬆️+1.93 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 1.59 GiB 3.52 GiB ⬆️+1.93 GiB
ValidationRunner.run 1.41 GiB 5.59 GiB ⬆️+4.17 GiB
dk-unknown-rejseplanen-gtfs-1292
GtfsFeedLoader.loadTables 1.77 GiB 2.08 GiB ⬆️+325.69 MiB
GtfsFeedLoader.executeMultiFileValidators 5.63 GiB 4.77 GiB ⬇️-876.68 MiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 5.63 GiB 4.77 GiB ⬇️-876.68 MiB
ValidationRunner.run 1.98 GiB 6.24 GiB ⬆️+4.26 GiB
au-new-south-wales-train-replacement-bus-operators-gtfs-1322
GtfsFeedLoader.loadTables 2.07 GiB 1.88 GiB ⬇️-192.98 MiB
GtfsFeedLoader.executeMultiFileValidators 6.09 GiB 4.71 GiB ⬇️-1.38 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 6.09 GiB 4.71 GiB ⬇️-1.38 GiB
ValidationRunner.run 1.95 GiB 6.37 GiB ⬆️+4.42 GiB
hu-unknown-volanbusz-gtfs-1836
GtfsFeedLoader.loadTables 1.91 GiB 1.88 GiB ⬇️-26.15 MiB
GtfsFeedLoader.executeMultiFileValidators 2.04 GiB 6.78 GiB ⬆️+4.74 GiB
org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.loadAndValidate 2.04 GiB 6.78 GiB ⬆️+4.74 GiB
ValidationRunner.run 2.86 GiB 1.94 GiB ⬇️-948.02 MiB

List of 25 datasets(no reference available).

Dataset ID Snapshot Key(Used Memory) Reference Latest

@emmambd emmambd added this to the 6.0 Validator Release milestone Oct 11, 2024
@@ -139,7 +139,8 @@ static class TripDistanceExceedsShapeDistanceNotice extends ValidationNotice {
}

/**
* The distance between the last shape point and last stop point is less than the 11.1m threshold.
* The distance between the last shape point and last stop point is greater than 0 but less than
* the 11.1m threshold.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope, and I guess I should know that by now, but why do we sometimes talk about 11.1m and sometimes 1.11m?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a long story :) We defined different thresholds per notice. Specific references to the rationale for each are in the 5.0 release notes: https://github.com/MobilityData/gtfs-validator/releases/tag/v5.0.0

@emmambd emmambd merged commit 1256b0d into master Oct 11, 2024
335 checks passed
@emmambd emmambd deleted the below-threshold-desc branch October 11, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants