-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Clarified below threshold language in notices #1886
Conversation
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit d6d4065 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
@@ -139,7 +139,8 @@ static class TripDistanceExceedsShapeDistanceNotice extends ValidationNotice { | |||
} | |||
|
|||
/** | |||
* The distance between the last shape point and last stop point is less than the 11.1m threshold. | |||
* The distance between the last shape point and last stop point is greater than 0 but less than | |||
* the 11.1m threshold. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope, and I guess I should know that by now, but why do we sometimes talk about 11.1m and sometimes 1.11m?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a long story :) We defined different thresholds per notice. Specific references to the rationale for each are in the 5.0 release notes: https://github.com/MobilityData/gtfs-validator/releases/tag/v5.0.0
Summary:
We received some user feedback that the
trip_distance_exceeds_shape_distance_below_threshold
andequal_shape_distance_diff_coordinates_below_threshold
notice language was confusing. Added description about the value being greater than 0 but below the threshold to more clearly convey this.Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything