-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: aling matrix dimensions to max concurrent jobs #1904
Conversation
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit ba5f107 📊 Notices ComparisonNew Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1602 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit ba5f107 📊 Notices ComparisonNew Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1602 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
The acceptance test was executed two times, and without many stats, it was completed faster than usual. The time was reduced to ~30 minutes from ~35-45 minutes. Billable time looks down by almost a half. This is not a statistical conclusion; we will monitor the performance of the acceptance tests in subsequent PRs. https://github.com/MobilityData/gtfs-validator/actions/runs/11465910593 |
Summary:
Currently, the number of concurrent jobs is limited by the type of account the organization is holding. As a Team account, we have 60 maximum number of jobs that can concurrently be executed at a time. Having 256 rows in the acceptance tests has two main issues. The first only 60 can be executed concurrently so having more than 60 will make the agents wait and don't add any value as a concurrent job. Secondly, the billable time is computed per second, but the minimum billable time is one minute; all the jobs completed before one minute will be charged one minute,
loosing
few seconds per small job.Expected behavior:
Acceptance tests passes and the resources are more efficient used.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything