Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #512 #516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #512 #516

wants to merge 1 commit into from

Conversation

efrederickson
Copy link

Apply the fix suggested in #512

Apply the fix suggested in MongoEngine#512
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 21, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.06%.

Quality metrics Before After Change
Complexity 2.73 ⭐ 2.73 ⭐ 0.00
Method Length 48.29 ⭐ 48.57 ⭐ 0.28 👎
Working memory 4.11 ⭐ 4.11 ⭐ 0.00
Quality 87.31% 87.25% -0.06% 👎
Other metrics Before After Change
Lines 102 102 0
Changed files Quality Before Quality After Quality Change
flask_mongoengine/json.py 87.31% ⭐ 87.25% ⭐ -0.06% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@gissimo gissimo mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant