Modify foreign asset creator benches to make them non-parametric #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
approved these changes
Apr 9, 2024
RomarQ
approved these changes
Apr 9, 2024
Agusrodri
approved these changes
Apr 9, 2024
girazoki
added a commit
to moondance-labs/moonkit
that referenced
this pull request
Apr 9, 2024
…nsong-Labs#36) * modify benche * remove parametric benchmarking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially built the pallet-foreign-asset-creator sbenchmarks with parametric number of assets being created but there is no influence in the pallet (as its mapping oriented) and this makes benchmarking harder as even if it does not influence it sometimes still creates a small weight dependency probably related to noise.
This PR removes these parametrics bounds