feat: ✨ add batching to user charging #229
Open
+1,644
−1,198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowmead
approved these changes
Oct 17, 2024
ffarall
approved these changes
Oct 18, 2024
| @@ -1270,6 +1270,136 @@ mod fixed_rate_streams { | |||
| }); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn charge_multiple_users_payment_streams_works() { | |||
There was a problem hiding this comment.
I would like to see also a test cases for:
- Three users charged at once:
- Bob: one fixed rate payment stream.
- Charlie: one dynamic rate payment stream.
- Dave: one fixed and one dynamic rate payment stream.
- Three users charged at once, but (for whatever reason) the third user charged should fail. Here check that none of the users end up charged.
| @@ -65,3 +65,6 @@ pub type UnitsProvidedFor<T> = <T as Config>::Units; | |||
| /// Syntactic sugar for the ProviderId type used in the proofs pallet. | |||
| pub type ProviderIdFor<T> = | |||
| <<T as crate::Config>::ProvidersPallet as ReadProvidersInterface>::ProviderId; | |||
|
|
|||
| /// Syntatic sugar for the maximum amount of Users a Provider can charge in a batch. | |||
There was a problem hiding this comment.
Suggested change
| /// Syntatic sugar for the maximum amount of Users a Provider can charge in a batch. | |
| /// Syntactic sugar for the maximum amount of Users a Provider can charge in a batch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds batching to BSPs charging users' payment streams and updates the BSP charge fees task to use the new functionality.