RoadRunner v1.0.0 migration #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs left around the codebase for things that still need migration or testing
Deprecated by Tasks
Will ditch the interface approach from old BunyipsLib and will attach task creation directly to the drive
# Conflicts: # src/main/java/au/edu/sa/mbhs/studentrobotics/bunyipslib/vision/AprilTagPoseEstimator.java
Should be reimplemented using the proper utils
RR1 works with splicing poses to avoid continuity errors, but the Pure Pursuit implementation relies on these old simpler paths. It is more streamlined to simply port over these pathing utils.
Since adjusting the pose will throw no errors, it may cause unexpected behaviour even if it is documented that the pose field is read-only. To keep it concise the 'estimate' phrase was removed from the getters and setters of Localizable.
SAM interface reorganisation (breaks some previous methods) Hard keyword aliases that are much more concise and documented
Run linting and annotations to support users in knowing nullable/non-null types
bubner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
DynIMUandGeometryDashboardutil