Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #8 (i don't really know how pull requests, forks, and remotes work)
Changes to #8:
batched_mul
function through NNlib instead of Flux to avoid unnecessary indirect dependenciesbackbone/distance.jl
tobackbone/bonds.jl
backbone_bond_vectors
function inbackbone/bonds.jl
bond_lengths
andbond_angles
variables toMEAN_BOND_LENGTH
andMEAN_BOND_ANGLE
turn into consts.module Dihedrals
with hopes of making the functions work well with theBackbone
typebond_lengths
andbond_angles
into keyword argumentsget_triangle
tolaw_of_cosines
::Backbone
method toget_dihedrals
function