Fix integer overflow calculating length of very large playlists #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcorporation
force-pushed
the
playlistlength_fix
branch
from
3ce06ad
to
cfc5bfa
Compare
|
This loses type safety by downgrading from std::chrono to raw integers, but what do these raw integers mean? You make the core more obscure and less safe. |
jcorporation
force-pushed
the
playlistlength_fix
branch
2 times, most recently
from
88eb713
to
80431be
Compare
|
Ok, migrated it to std::chrono::duration api. |
src/playlist/Length.cxx
Outdated
Comment on lines
47
to
48
| const auto seconds = std::chrono::duration_cast<std::chrono::seconds>(playtime); | ||
| r.Fmt(FMT_STRING("playtime: {}\n"), seconds.count()); |
There was a problem hiding this comment.
This removes the rounding which was very explicit previously
There was a problem hiding this comment.
Replaced with std::chrono::round
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| static SignedSongTime get_duration(const DetachedSong &song) { | |||
| const auto duration = song.GetDuration(); | |||
| return duration.IsNegative() ? (SignedSongTime)0 : song.GetDuration(); | |||
| return duration.IsNegative() ? (SignedSongTime)0 : duration; | |||
There was a problem hiding this comment.
As I get the song duration in the local variable there is no need to call the GetDuration function a second time.
There was a problem hiding this comment.
True, but it doesn't fix an integer overflow
jcorporation
force-pushed
the
playlistlength_fix
branch
from
80431be
to
052719c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.