meson.build: support building with ICU 76 #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib/icu/meson.build
Outdated
| conf.set('HAVE_ICU', icu_dep.found()) | ||
| icu_i18n_dep = dependency('icu-i18n', version: '>= 50', required: get_option('icu')) | ||
| icu_uc_dep = dependency('icu-uc', version: '>= 50', required: get_option('icu')) | ||
| conf.set('HAVE_ICU', icu_i18n_dep.found()) |
There was a problem hiding this comment.
What if icu-i18n was found but not icu_uc?
There was a problem hiding this comment.
I can update to check both.
In theory, should be an unlikely scenario as icu-i18n has always used icu-uc. Though I guess there is no guarantee on what ICU will do in future.
There was a problem hiding this comment.
True, this should be both available, but since this is out of our control, and users may do stupid things (and some will do), let's be sure, and it's so simple to check both...
ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer add `icu-uc` when linking to shared libraries. This results in failure: ``` src/lib/icu/libicu.a.p/Converter.cxx.o: undefined reference to symbol 'ucnv_fromUnicode_76' ``` [^1]: unicode-org/icu@199bc82
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICU 76 decided to reduce overlinking1 thus
icu-i18nwill no longer addicu-ucwhen linking to shared libraries. This results in failure:ICU 76:
ICU 75
Footnotes
https://github.com/unicode-org/icu/commit/199bc827021ffdb43b6579d68e5eecf54c7f6f56 ↩