-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add an html + javascript example #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the example, @jpcsmith. I don't know much about JS, so I can't comment much on the code itself.
But I ran it locally and it works! 💯
Just two optional suggestions from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not a JS guru here (in fact n00b) but tested it and it works. Just one suggestion below to add a few links:
- Can we add a link to a Sui explorer so that people can go see their object (ensure its pointing to testnet).
- Since this is web, can we add a link to the Walrus docs?
544be70
to
5a58cf6
Compare
Hey @mlegner, could you just briefly do a sanity pass by running this on your own machine to ensure I didnt miss break anything for others? Otherwise it's ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, @jpcsmith! Runs very smoothly, just noticed some very minor issues.
This adds a javascript + HTML example.
Depends on walrus #515 to enable PUT requests from browsers to the client daemon.
If you feel this is too complicated, let me know and I can simplify it.
TODO:
Contributes to #11