Handle Middle Click Drag for Environment Control #789
Conversation
Handle Middle Click Drag for Environment Control
| // use LOG to scale the scroll delta and hopefully normalize them across platforms | ||
| const deltaSign = Math.sign( delta ); | ||
| const normalizedDelta = Math.log( Math.abs( delta ) + 1 ); | ||
| this.zoomDelta -= 3 * deltaSign * normalizedDelta * 1; |
There was a problem hiding this comment.
Log scale shouldn't be needed if we're moving in screen space. It's used because the reported wheel "scroll" has pretty severely different magnitudes depending on platform.
+ these two calls are not necessary: ```js // this._updateZoomDirection(); // this.needsUpdate = true; ```
|
Just got back home and tested it with a mouse - as you allude to in #788, I'm seeing that the drag point shifts as you move the mouse around. This is probably because the "zoom direction" is getting reset in different conditions. Like when the pointer moves and the ellipsoid frame has been rotated. These are both cases that are valid when using pinch-to-zoom on mobile, though (since you may move your fingers around to zoom to different spots) so we'll need to be careful to not break that case when addressing regenerating the zoom direction. |
Following issue #788
Handle Middle Click Drag for Environment Control