fix(ruleset): own pull request merge controls - #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Make GDS own and verify the pull-request parameters that can independently block or broaden merge behavior:
require_last_push_approvalrequire_extra_approval_for_unattributed_changesallowed_merge_methodsThe provider now decodes, normalizes, emits, compare-and-swap updates, and verifies the pull-request rule together with required status checks. Externally managed reviewer/dismissal fields remain losslessly preserved.
This fixes a created ruleset where GitHub defaulted extra unattributed approval to true while GDS verification ignored it.
Evidence
go test ./...go build -trimpath ./core/cmd/gds