Skip to content

fix(ruleset): preserve external pull parameters - #17

Merged
rldyourmnd merged 1 commit into
mainfrom
fix/preserve-pull-request-external-params
Aug 22, 2026
Merged

fix(ruleset): preserve external pull parameters#17
rldyourmnd merged 1 commit into
mainfrom
fix/preserve-pull-request-external-params

Conversation

@rldyourmnd

Copy link
Copy Markdown
Contributor

Outcome

Make pull-request ruleset updates lossless while GDS owns merge controls.

  • request mutation replaces typed owned fields
  • required_reviewers, dismissal_restriction, and future external parameters are preserved
  • expected postcondition carries the same external parameters
  • provider read-back can now verify the exact state instead of marking a successful GitHub update partial

This follows live evidence where GitHub accepted the desired merge controls but GDS postcondition lost external defaults.

Evidence

  • provider mutation regression
  • ruleset expected-state regression
  • app/provider/ruleset suites
  • quick Go validation
  • portable synthetic fixtures only

@rldyourmnd
rldyourmnd merged commit 8455ab1 into main Aug 22, 2026
2 checks passed
@rldyourmnd
rldyourmnd deleted the fix/preserve-pull-request-external-params branch August 22, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant