Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checkruntimejobs output #41

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Improve checkruntimejobs output #41

merged 1 commit into from
Oct 10, 2024

Conversation

martialblog
Copy link
Member

@martialblog martialblog commented Sep 23, 2024

  • The query assumed a string and used LIKE, probably from an older iteration of the plugin. Now uses IN syntax to support multiple states

See #40

@martialblog martialblog self-assigned this Sep 23, 2024
@martialblog
Copy link
Member Author

@mowgli This should fix the issue with the runtimejobs query and improve the output. Can you verify that?

@mowgli
Copy link

mowgli commented Sep 23, 2024 via email

@martialblog
Copy link
Member Author

Meh -.- guess I have to setup a Bareos Database to fix this. I'll keep you posted

@martialblog martialblog marked this pull request as draft September 24, 2024 06:24
@martialblog martialblog added this to the v2.1.1 milestone Sep 24, 2024
@martialblog martialblog marked this pull request as ready for review September 30, 2024 07:37
@martialblog martialblog changed the title Fix wrong query in checkruntimejobs Improve checkruntimejobs output Sep 30, 2024
@martialblog
Copy link
Member Author

@mowgli Ok upon closer look the query looks alright and seems to work with Bareos 23.0.4.

I extended the output of the plugin so that it is clearer what is happening. As mentioned in the issue, I think the the -st parameter is what you need.

@martialblog martialblog merged commit a675427 into main Oct 10, 2024
2 checks passed
@martialblog martialblog deleted the fix/runtimequery branch October 10, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants