Merge pull request #620 from NOAA-EMC/jba_testlibdir

correct the tables definitions of two local variables
NOAA-EMC · Sep 18, 2024 · 7ba7a8f · 7ba7a8f
2 parents 9d4e0ee + 2647802
commit 7ba7a8f
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 27 deletions.
diff --git a/.github/workflows/Intel.yml b/.github/workflows/Intel.yml
@@ -54,7 +54,7 @@ jobs:
       uses: actions/cache@v4
       with:
         path: ~/data
-        key: data-16
+        key: data-17
 
     - name: build
       run: |

diff --git a/.github/workflows/Linux.yml b/.github/workflows/Linux.yml
@@ -40,7 +40,7 @@ jobs:
       uses: actions/cache@v4
       with:
         path: ~/data
-        key: data-16
+        key: data-17
 
     - name: build
       run: |

diff --git a/.github/workflows/MacOS.yml b/.github/workflows/MacOS.yml
@@ -45,7 +45,7 @@ jobs:
       uses: actions/cache@v4
       with:
         path: ~/data
-        key: data-16
+        key: data-17
 
     - name: build-bufr
       run: |

diff --git a/.github/workflows/Spack.yml b/.github/workflows/Spack.yml
@@ -42,7 +42,7 @@ jobs:
       uses: actions/cache@v4
       with:
         path: ~/data
-        key: data-16
+        key: data-17
 
     - name: spack-build-and-test
       run: |

diff --git a/.github/workflows/developer.yml b/.github/workflows/developer.yml
@@ -38,7 +38,7 @@ jobs:
       uses: actions/cache@v4
       with:
         path: ~/data
-        key: data-16
+        key: data-17
 
     - name: build-docs
       run: |

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -27,7 +27,7 @@ option(BUILD_TESTING "Enable automated testing" ON)
 # Developers can use this option to specify a local directory which
 # holds the test files. They will be copied instead of fetching the
 # files via FTP.
-SET(TEST_FILE_DIR "." CACHE STRING "Check this directory for test files before using FTP.")
+set(TEST_FILE_DIR "." CACHE STRING "Check this directory for test files before using FTP.")
 message(STATUS "Finding test data files in directory ${TEST_FILE_DIR}.")
 
 set(MASTER_TABLE_DIR "${CMAKE_INSTALL_PREFIX}/tables" CACHE STRING "Installation location of Master BUFR Tables")
@@ -125,8 +125,8 @@ endif()
 
 add_subdirectory(tables)
 
-# Turn on unit testing.
 if(BUILD_TESTING)
+  # Turn on unit testing.
   include(CTest)
   add_subdirectory(test)
 endif()

diff --git a/README.md b/README.md
@@ -64,7 +64,7 @@ must be installed and available on the system.
 
 When building the library, automated CI testing is included by default.
 If this is not desired, then it can be disabled by adding `-DBUILD_TESTING=OFF`
-to the above cmake command.
+to the above cmake command and omitting the subsequent `ctest` step.
 
 When building the library, associated utilities are included by default.
 If these are not desired, then they can be disabled by adding `-DBUILD_UTILS=OFF`

diff --git a/tables/bufrtab.CodeFlag_LOC_0_7_1 b/tables/bufrtab.CodeFlag_LOC_0_7_1
@@ -1,7 +1,7 @@
 Table F LOC |  0 | 7 |  1
 #
 # Local BUFR Table CODE/FLAG, Master Table 0, Originating Center 7, Version 1
-# This file was generated: 2024/07/05 17:36:49
+# This file was generated: 2024/09/16 19:31:11
 #
 #========================================================================================================
 # F-XX-YYY | MNEMONIC ; CODE               <-- code table definition
@@ -2854,21 +2854,16 @@ Table F LOC |  0 | 7 |  1
               | 12 > | Dew point sensor invalidated
               | 16   | Operator manual data entry
 
-  0-33-241 | QHDOP ; CODE
-              | 0 > | All parameters of nominal accuracy
-              | 1 > | Latitude or longitude questionable
-              | 2 > | Geopotential altitude or static pressure questionable
-              | 3   | Both latitude or longitude, and geopotential altitude or static pressure questionable
-
-  0-33-242 | QHDOM ; CODE
-              | 0 > | All parameters of nominal accuracy
-              | 1 > | Temperature or dewpoint temperature questionable
-              | 2 > | Flight-level winds questionable
-              | 3 > | SFMR parameter(s) questionable
-              | 4 > | Temperature or dewpoint temperature, and flight-level winds questionable
-              | 5 > | Temperature or dewpoint temperature, and SFMR parameter(s) questionable
-              | 6 > | Flight-level winds and SFMR parameter(s) questionable
-              | 9   | Temperature or dewpoint temperature, flight-level winds, and SFMR parameter(s) questionable
+  0-33-241 | QHDOP ; FLAG
+              | 1 > | All parameters of nominal accuracy
+              | 2 > | Latitude or longitude questionable
+              | 3   | Geopotential altitude or static pressure questionable
+
+  0-33-242 | QHDOM ; FLAG
+              | 1 > | All parameters of nominal accuracy
+              | 2 > | Temperature or dewpoint temperature questionable
+              | 3 > | Flight-level winds questionable
+              | 4   | SFMR parameter(s) questionable
 
   0-33-254 | TPQC2 ; CODE
               | 0 > | Good
@@ -4762,6 +4757,7 @@ Table F LOC |  0 | 7 |  1
               | 14 > | France ASDAR/ACARS
               | 15 > | Flight level reconnaisance (High Density Observations)
               | 16 > | Mode-S ASDAR/ACARS
+              | 17 > | AMDAR-over-AFIRS
               | 30 > | Long-duration balloon
               | 103 > | ASDAR/ACARS (BUFR)
            | 0-55-020=5

diff --git a/tables/bufrtab.TableB_LOC_0_7_1 b/tables/bufrtab.TableB_LOC_0_7_1
@@ -1,7 +1,7 @@
 Table B LOC |  0 | 7 |  1
 #
 # Local BUFR Table B, Master Table 0, Originating Center 7, Version 1
-# This file was generated: 2024/07/05 17:36:49
+# This file was generated: 2024/09/16 19:31:11
 #
 #========================================================================================================
 # F-XX-YYY |SCALE| REFERENCE   | BIT |      UNIT         | MNEMONIC ;DESC ;  ELEMENT NAME
@@ -427,8 +427,8 @@ Table B LOC |  0 | 7 |  1
   0-33-238 |   0 |           0 |   6 | Code table        | QCCHEK   ;     ; Data quality check indicator
   0-33-239 |   0 |           0 |   3 | Code table        | QCTSP    ;     ; Quality control indicator for temperature/salinity profile
   0-33-240 |   0 |           0 |   3 | Code table        | QCCUR    ;     ; Quality control indicator for current profile
-  0-33-241 |   0 |           0 |   3 | Code table        | QHDOP    ;     ; Quality for observed position
-  0-33-242 |   0 |           0 |   4 | Code table        | QHDOM    ;     ; Quality for observed meteorological parameters
+  0-33-241 |   0 |           0 |   7 | Flag table        | QHDOP    ;     ; Quality for observed position
+  0-33-242 |   0 |           0 |  15 | Flag table        | QHDOM    ;     ; Quality for observed meteorological parameters
   0-33-245 |   2 |           0 |  16 | K                 | SSTE     ;     ; Estimated error covariance for sea surface temperature retrieval
   0-33-246 |   2 |           0 |  15 | m s**-1           | SPDE     ;     ; Estimated error covariance for wind speed retrieval
   0-33-247 |   2 |           0 |  14 | kg m**-2          | VPRE     ;     ; Estimated error covariance for total water vapor retrieval