Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python bin path and docs #528

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

AlexanderRichert-NOAA
Copy link
Contributor

In #524, I missed a path that should be updated for consistency (to avoid building prepbufr2nc directly into the install path). This PR fixes that, as well as the pdoc build.

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review October 4, 2023 20:23
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbathegit
Copy link
Collaborator

Thanks @AlexanderRichert-NOAA

Just curious, since you mentioned pdoc (and since no good deed goes unpunished :-), do either of you have any idea how to address #230 or can tell me what I was doing wrong there or how to update pdoc? That issue has been sitting open for over a year now.

@jbathegit jbathegit merged commit 3e91d82 into NOAA-EMC:develop Oct 5, 2023
6 checks passed
@AlexanderRichert-NOAA
Copy link
Contributor Author

I'd be happy to take a crack at it-- I'm assuming that you want that to go into the docs artifact in the 'developer' CI?

@jbathegit
Copy link
Collaborator

Yes, that would be a perfect place for it - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants