increase maximum message size in debufr utility #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbathegit
requested review from
edwardhartnett,
AlexanderRichert-NOAA and
jack-woollen
|
Is there a corresponding issue for the message length change? |
No I didn't write one up b/c it was literally a one-line change, and it came about b/c of an email from a WCOSS2 user who was having trouble using debufr to read through a file. As I looked into the issue it became clear it was because some of the messages the user was trying to read were upwards of 4Mb in size, and the utility previously had an upper limit of 2.5Mb. |
|
Hi @AlexanderRichert-NOAA @jack-woollen @edwardhartnett Are there any remaining comments or concerns about this PR? If not, could someone please approve it so I can go ahead and merge it? (Thanks! :-) |
edwardhartnett
approved these changes
Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also relocated an initialization loop to improve runtime efficiency, per discussion in #625
Also cleaned up an address sanitizer issue that had been showing up in the developer runner for subroutine rewnbf