Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix build capability for Gaea-C5, Gaea-C6, and container #87

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

DavidBurrows-NCO
Copy link
Contributor

Description

After the recent Gaea-C5 OS upgrade, gfs_utils fails to build.
This corrects Gaea-C5 build, adds Gaea-C6 build capability (following ufs-wx-model 2448), and adds containerized build capability.

Refs NOAA-EMC/global-workflow 3011
Refs NOAA-EMC/global-workflow 3025
Resolve #86

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Cloned and built on Gaea-C5, Gaea-C6, and container

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

elif [[ $MACHINE_ID = container ]] ; then
# We are in a container
if ( ! eval module help > /dev/null 2>&1 ) ; then
source /usr/lmod/lmod/init/bash

Check notice

Code scanning / shellcheck

Not following: /usr/lmod/lmod/init/bash: openBinaryFile: does not exist (No such file or directory) Note

Not following: /usr/lmod/lmod/init/bash: openBinaryFile: does not exist (No such file or directory)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-a-potts Is source /usr/lmod/lmod/init/bash needed for the container?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is needed if you don't use the /bin/mybash script when you shell in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gfs_utils fails to build on Gaea-C5 after OS upgrade
2 participants