Revive CI tests for release mode #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code will crash in debug mode, due to a floating point exception which is still being explored. This PR includes minor bug fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes fixes necessary to get the linux Intel and GNU CI tests to work again for release mode. Testing in debug mode does not work yet due to a floating point exception traced to an initialization problem of one or more fields. This update gets at least some CI tests in working order. Once the floating point bug is fixed, the results will likely change again, so the baseline will need updating again.
This PR includes a few minor fixes needed to get CI functional. One was adding MPI_Finalize() call to the test code. Others include adding support for LLVM Intel builds and updating the installation of compilers and MPI in the CI workflow configs.