Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tas 1 login form #30

Merged
merged 17 commits into from
Mar 31, 2024
Merged

Conversation

AndrewJanong
Copy link
Contributor

Pull Request

Description

Created the login form and added a component for the NFS login image.

Related Issues

Checklist

Please review and check the following before submitting your pull request:

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have written tests for my changes (if applicable).
  • All new and existing tests passed.
  • I have updated the documentation accordingly (if applicable).
  • I have added comments to my code, particularly in areas that may be confusing.

Screenshots (if applicable)

Desktop

image

image

Mobile

Additional Information

The components were made with fixed sizes, so might need to change later.

Reviewer Notes

@AndrewJanong AndrewJanong self-assigned this Mar 14, 2024
@gnimnix
Copy link
Contributor

gnimnix commented Mar 19, 2024

Hi @AndrewJanong , after importing the components, the form looks like this now, could u help fix it?
Also could u include the helper methods so that signIn() gets called when the user clicks submit, thx!
image

@gnimnix gnimnix self-requested a review March 19, 2024 12:13
@gnimnix gnimnix added the enhancement New feature or request label Mar 19, 2024
@gnimnix
Copy link
Contributor

gnimnix commented Mar 25, 2024

@AndrewJanong , you need to change the form in WebLoginContainer.module.css and MobileLoginContainer.module.css. Could you integrate them with the parent component? thx!

@gnimnix gnimnix merged commit 2a156bf into epic/DEV-3-authentication Mar 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants