Add device-side ETKDG conformer pruning - #265
Conversation
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
|
| Filename | Overview |
|---|---|
| src/conformer/device_conformer_pruning.cpp | Prepares RDKit atom mappings, launches pruning, and compacts retained coordinates while preserving device-result metadata; no follow-up-eligible issue was identified. |
| src/conformer_rmsd.cu | Adds symmetry-aware aligned RMSD and ordered greedy pruning kernels; no follow-up-eligible issue was identified. |
| src/etkdg.cpp | Enables pruning after device-output collection while leaving the host conformer path unchanged. |
| tests/test_etkdg_device_output.cu | Expands coverage for device pruning behavior, ordering, symmetry, heavy atoms, compaction, and conformer-index renumbering. |
Reviews (3): Last reviewed commit: "Merge official/main into pr-265" | Re-trigger Greptile
|
Thanks for closing another feature gap! I'll be able to review this later today or tomorrow. Don't worry about the python build failures, I need to fix our CI from our v0.6 version bump. C++ build is the important one to look at. |
scal444
left a comment
There was a problem hiding this comment.
Looks great! A few small things, and one performance suggestion that can definitely be left to a followup, or handled here.
|
Awesome! Thanks for taking a look, will fix those issues and take another deep look before the weekend |
|
Also our CI should be fixed now so if you rebase onto or merge in |
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
|
Applied the fixes. Also applied your suggestion to use a list of the retained conformers so that we don't waste time on those no ops; although it was done in place with the list containing conformers ( |
scal444
left a comment
There was a problem hiding this comment.
Approved pending CI, thanks!
|
I am faling during the build phase of the CI/CD pipeline, but it seems it is due to a Github issue, A Github action is timing out. Can you please trigger a rerun? |
Summary