Skip to content

Add nvskills workflow file - #283

Open
ohadmo wants to merge 4 commits into
mainfrom
omosafi/nvskills
Open

Add nvskills workflow file#283
ohadmo wants to merge 4 commits into
mainfrom
omosafi/nvskills

Conversation

@ohadmo

@ohadmo ohadmo commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@ohadmo ohadmo self-assigned this Aug 26, 2026
@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds publication and evaluation artifacts for the nvmolkit-usage skill and updates its descriptive metadata.

  • Adds the generated benchmark report and signed provenance bundle.
  • Updates the skill card with evaluation results, supported outputs, requirements, references, and version information.
  • Includes a temporary CI-touch change to the skill documentation.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains; the previously reported workflow-discovery issue is absent because the workflow is currently located under .github/workflows/.

Important Files Changed

Filename Overview
skills/nvmolkit-usage/BENCHMARK.md Adds the completed NVSkills benchmark report, including provenance, tier status, scores, and validator observations.
skills/nvmolkit-usage/SKILL.md Adds a temporary documentation-only marker used to trigger NVSkills CI validation.
skills/nvmolkit-usage/skill-card.md Updates publication metadata and replaces pending evaluation details with completed benchmark results.
skills/nvmolkit-usage/skill.oms.sig Adds the signed provenance bundle covering the skill’s publication artifacts.

Reviews (6): Last reviewed commit: "Attach NVSkills validation signatures" | Re-trigger Greptile

Comment thread .github/workflows/request-nvskills-ci.yml
@ohadmo

ohadmo commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@evasnow1992

Copy link
Copy Markdown
Collaborator

Hi Ohad, thank you for adding the nvSkill workflow. Kevin is currently OOO and will complete the review when he's back. In the meantime, I also took a look at the changes and have a couple of general comments:

  1. I think the issue Greptile raised is valid: the YAML file needs to be under .github/workflows/ for the workflow to be triggered.
  2. The file is also missing the SPDX header required for our repo:
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

@ohadmo

ohadmo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@ohadmo

ohadmo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@ohadmo

ohadmo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@scal444

scal444 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Which parts of this should actually be merged? Is it just the skill card?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants