Fixes problems with fetching LFS objects during nvImageCodec conda build #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI MESSAGE: [17359850]: BUILD STARTED |
jantonguirao
approved these changes
Aug 9, 2024
|
CI MESSAGE: [17359850]: BUILD FAILED |
|
Reported in conda/conda-build#5452. |
- conda does bare mirror first and then clones the code to the build dir it also fetches the LFS object, but it does that only for the built reference, if there are other objects they are left out. Then it does the full cone and checkout and that is why it complains about missing objects. Also, it doesn't allow running any post-clone hooks. see conda/conda-build#1462 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
fix_nvimage_conda_build
branch
from
0e29599
to
42e89be
Compare
|
CI MESSAGE: [17360826]: BUILD STARTED |
|
CI MESSAGE: [17360826]: BUILD PASSED |
awolant
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it also fetches the LFS object, but it does that only for the built reference, if there are
other objects they are left out. Then it does the full cone and checkout and that is why it
complains about missing objects. Also, it doesn't allow running any post-clone hooks.
see Clone fails if source has LFS files conda/conda-build#1462
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
it also fetches the LFS object, but it does that only for the built reference, if there are
other objects they are left out. Then it does the full cone and checkout and that is why it
complains about missing objects. Also, it doesn't allow running any post-clone hooks.
see Clone fails if source has LFS files conda/conda-build#1462
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A