Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 (experimental) support #5692

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

jantonguirao
Copy link
Contributor

@jantonguirao jantonguirao commented Oct 30, 2024

Category:

Other (add one more python version)

Description:

  • Added Python 3.13 support

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • [x ] N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19904234]: BUILD STARTED

Signed-off-by: Joaquin Anton Guirao <janton@nvidia.com>
Signed-off-by: Joaquin Anton Guirao <janton@nvidia.com>
@jantonguirao jantonguirao changed the title Add py313 to tegra builder Add Python 3.13 (experimental) support Oct 30, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19904234]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19907864]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19907864]: BUILD FAILED

Signed-off-by: Joaquin Anton Guirao <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19915010]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19915010]: BUILD PASSED

@JanuszL JanuszL self-assigned this Oct 31, 2024
@JanuszL JanuszL self-requested a review October 31, 2024 07:49
@mzient mzient self-assigned this Oct 31, 2024
Comment on lines +30 to +33
python3.9 python3.9-dev \
python3.10 python3.10-dev \
python3.11 python3.11-dev \
python3.12 python3.12-dev \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to distutils? Don't we need them any more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently not. And it seems there's no python3.13-distutils. That's why I tried removing it altogether and I didn't find any issues.

@jantonguirao jantonguirao merged commit e27d0de into NVIDIA:main Nov 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants