Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper NVTX markers to Executor2. #5694

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Oct 30, 2024

Category:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Description:

This fixes and extends NVTX markers and thread names in Executor 2.0.

  • proper names
  • proper coloring (CPU/GPU/Mixed)
  • more ranges
  • executor threads now have a name [DALI] Executor

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19920147]: BUILD STARTED

@JanuszL JanuszL self-assigned this Oct 30, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19920147]: BUILD PASSED

@@ -91,6 +92,7 @@ class Executor2::Impl {
};

void Build(const graph::OpGraph &graph) {
DomainTimeRange tr("[DALI][Executor] Build");
Copy link
Member

@szalpal szalpal Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about omitting the [DALI] tag, since the Domain is already named "DALI"?

Suggested change
DomainTimeRange tr("[DALI][Executor] Build");
DomainTimeRange tr("[Executor] Build");

Copy link
Contributor Author

@mzient mzient Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may have a merit - but then I guess we should revisit all NVTX markers and drop [DALI], otherwise this would stand out.

@mzient mzient merged commit 0da30ea into NVIDIA:main Oct 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants