Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointwise shouldn't check transpose scheduler #3256

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

naoyam
Copy link
Collaborator

@naoyam naoyam commented Oct 22, 2024

Removed unnecessary check.

Codegen diff kept failing with some python tests, which was due to #3283. Otherwise, no change is detected.

@naoyam
Copy link
Collaborator Author

naoyam commented Oct 22, 2024

!build --diff

jacobhinkle and others added 2 commits October 23, 2024 13:20
Our improper handling of pytest log output led to failures in codediff
CI jobs in the past day or so. I removed the splitting-based parser code
and improved the regex approach. I tested with the artifact from a
recent failing job and it worked.
@naoyam
Copy link
Collaborator Author

naoyam commented Oct 23, 2024

!build --diff

1 similar comment
@naoyam
Copy link
Collaborator Author

naoyam commented Oct 23, 2024

!build --diff

@naoyam
Copy link
Collaborator Author

naoyam commented Oct 24, 2024

!build --diff

@naoyam
Copy link
Collaborator Author

naoyam commented Oct 24, 2024

!build --diff

1 similar comment
@naoyam
Copy link
Collaborator Author

naoyam commented Oct 24, 2024

!build --diff

@naoyam
Copy link
Collaborator Author

naoyam commented Oct 25, 2024

!build --diff

@naoyam
Copy link
Collaborator Author

naoyam commented Oct 25, 2024

!build --diff-bench

@naoyam naoyam marked this pull request as ready for review October 26, 2024 02:58
@naoyam
Copy link
Collaborator Author

naoyam commented Oct 26, 2024

!build --diff-bench

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants