-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch potential segfault #3262
base: main
Are you sure you want to change the base?
patch potential segfault #3262
Conversation
!build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a repro?
!build |
!build |
Saw this in the CI that could be relevant.
Oops, indeed caused by the changes in this PR. Working on it now. |
…t' into patch_move_pad_potential_segfault
!build |
!build |
tagging @naoyam for the added test. |
!build |
!build |
CI looks promising. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not sure how this could happen.