Address more comments

NVIDIA · May 10, 2024 · 08ff39f · 08ff39f
1 parent 82f7863
commit 08ff39f
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/.github/workflows/_build_base.yaml b/.github/workflows/_build_base.yaml
@@ -85,6 +85,10 @@ jobs:
             fi
 
             # try to get NCCL version from provided BASE_IMAGE of ARM64-arch
+            if [[ -z "$BASE_IMAGE" ]]; then
+              echo "Need to pass non-empty BASE_IMAGE variable"
+              exit 1
+            fi
             source .github/workflows/scripts/get_remote_env.sh
             JAX_LIBNCCL_PACKAGE=$(get_remote_env ${BASE_IMAGE:-ubuntu} linux amd64 | jq -r '.[]' | egrep '^NV_LIBNCCL_PACKAGE')
             JAX_NCCL_VERSION=$(get_remote_env ${BASE_IMAGE:-ubuntu} linux amd64 | jq -r '.[]' | egrep '^NCCL_VERSION=' | cut -d= -f2-)