Skip to content

Commit

Permalink
Always remove eval checkpoints in test-pax.sh (#810)
Browse files Browse the repository at this point in the history
Currently, eval checkpoints are only removed if the eval tests succeed.
In this PR, we remove the checkpoints in the case of failure as well.
  • Loading branch information
ashors1 authored May 9, 2024
1 parent 314c961 commit 98c45aa
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/container/test-pax.sh
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,9 @@ else
fi

if [[ ${EVALUATE} -ne 0 ]]; then

trap "rm -rf ${OUTPUT}/checkpoints" ERR INT HUP TERM EXIT

## train for 0 steps to generate an initial checkpoint
python -m paxml.main \
--fdl_config=${CONFIG} \
Expand All @@ -408,7 +411,6 @@ if [[ ${EVALUATE} -ne 0 ]]; then
$ADDITIONAL_ARGS \
$([[ $MULTIPROCESS != 0 ]] && echo --multiprocess_gpu)

rm -rf ${OUTPUT}/checkpoints
else
python -m paxml.main \
--fdl_config=${CONFIG} \
Expand Down

0 comments on commit 98c45aa

Please sign in to comment.