-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PR refs for jax or xla #116
Conversation
as the parent of t5x and pax instead of jax-te
Could you please provide an example of how PRs are specified for a build? |
Sure. So for this PR: https://github.com/openxla/xla/pull/4044/files You'd specify it in the |
We can make it more intuitive. Given that a PR is referenced in GitHub Flavored Markdown by
There is a small chance of conflict if a branch is named by a decimal integer, which is extremely rare in practice. The chance that it collides with a commit hash is also negligible. Moreover, this job might be a better place to host such logic. The idea is to keep the Dockerfile clean and independent of the CI workflow. We can detect if the content after |
That's cool! I didn't realize that was that syntax in GH markdown.
We can definitely move the logic that converts integers to PR git-refs I can make the change to accept a decimal instead. |
Closing this as it complicates the dockerfile. Better ways of handling this were discussed offline like potentially moving the logic of fetching github git refs outside of the dockerfile |
We already allow standard git-refs to be configurable in the build for xla and jax.
This change makes it possible to specify a PR git-ref so we can test an experimental change.