Ship Transformer Engine in the JAX container #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrykong
reviewed
Jul 19, 2023
| # Transformer Engine installation dependencies | ||
| pip install --no-cache-dir pybind11 ninja packaging | ||
| # Install JAX + Transformer Engine | ||
| NVTE_FRAMEWORK=jax pip --disable-pip-version-check --no-cache-dir install -e \ |
There was a problem hiding this comment.
I'm wondering what you think about setting ENV NVTE_FRAMEWORK=jax. Since we must set that environment variable to correctly install TE, it seems more friendly for re-installs. For example, when installing t5x next, it'll look something like pip install -e /opt/transformer-engine -e /opt/t5x and if NVTE_FRAMEWORK is set in the base container, we can save a few characters when installing
There was a problem hiding this comment.
The env variable isn't needed anymore if jax is already installed.
By default, the setup.py file try to import all the fw and will build for those installed.
yhtang
added a commit
that referenced
this pull request
Oct 13, 2023
…mber limit Will try to land #132 ASAP as a substitution.
|
Completed in #371. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging this, we will no longer build new
ghcr.io/nvidia/jax-teimages. Instead,ghcr.io/nvidia/jaxwill always ship with TE.