Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triton: use CUDA 12.3 tools from the base image #656

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Triton: use CUDA 12.3 tools from the base image #656

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68bac2b
Triton: use CUDA 12.3 tools from the base image
olupton Mar 22, 2024
131f4a6
Check paths exist
olupton Mar 22, 2024
7fb211f
Update .github/container/Dockerfile.triton
olupton Mar 22, 2024
fe2f64f
-f -> -x
olupton Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/container/Dockerfile.triton
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,21 @@
ARG BASE_IMAGE=ghcr.io/nvidia/jax-mealkit:jax
ARG SRC_PATH_TRITON=/opt/openxla-triton

FROM ${BASE_IMAGE} as base
# Triton setup.py downloads and installs CUDA binaries at specific versions
# hardcoded in the script itself:
# https://github.com/openxla/triton/blob/84f9d9de158fb866fac67970f0f5d323999d9db1/python/setup.py#L373-L393
# Tell Triton to use CUDA binaries from the host container instead. These should be set
# both during the build stage and in the final container.
ENV TRITON_PTXAS_PATH=/usr/local/cuda/bin/ptxas
ENV TRITON_CUOBJDUMP_PATH=/usr/local/cuda/bin/cuobjdump
ENV TRITON_NVDISASM_PATH=/usr/local/cuda/bin/nvdisasm
RUN [ -x "${TRITON_PTXAS_PATH}" ] && [ -x "${TRITON_CUOBJDUMP_PATH}" ] && [ -x "${TRITON_NVDISASM_PATH}" ]

###############################################################################
## Check out Triton source and build a wheel
###############################################################################
FROM ${BASE_IMAGE} as builder
FROM base as builder

ARG SRC_PATH_TRITON

Expand Down Expand Up @@ -38,7 +49,7 @@ RUN rm -rf "${SRC_PATH_TRITON}/python/build"
###############################################################################
## Download source and add auxiliary scripts
###############################################################################
FROM ${BASE_IMAGE} as mealkit
FROM base as mealkit

ARG SRC_PATH_TRITON

Expand Down
Loading