Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine all workflow metrics into single summary #666

Closed
wants to merge 16 commits into from

Conversation

CliveUnger
Copy link
Contributor

Combine sitrep, status, and metric_summary for each test into a single summary json at the end.

The goal is capturing a complete picture of a Workflow Run: each build success/fail, each test success/fail, the metrics for each test and also metadata like what image the tests ran on and such. This data should be all pulled from a single artifact file.

@CliveUnger
Copy link
Contributor Author

I have an example in sandbox of this working here: https://github.com/NVIDIA/JAX-Toolbox/actions/runs/8461564960

There are some caveats:

  • The metrics_summary.json isn't included since in the sandbox I am reusing artifacts from an existing worfklow.
  • The artifact path was hardcoded. This would be fixed before merging.

.github/workflows/_finalize.yaml Outdated Show resolved Hide resolved
.github/workflows/_finalize.yaml Show resolved Hide resolved
@CliveUnger
Copy link
Contributor Author

Do I need to revert the changes to _sandbox.yaml before this goes in?

@olupton
Copy link
Collaborator

olupton commented Apr 9, 2024

Do I need to revert the changes to _sandbox.yaml before this goes in?

Yes please.

@CliveUnger
Copy link
Contributor Author

I am running a full "CI" workflow on this change here: https://github.com/NVIDIA/JAX-Toolbox/actions/runs/8620819287

If this completes successfully, this PR should be good to go.

@CliveUnger
Copy link
Contributor Author

Closing, will re-open from repo branch.

@CliveUnger CliveUnger closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants