Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add praxis grok DPA patch #889

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Add praxis grok DPA patch #889

merged 1 commit into from
Jun 11, 2024

Conversation

ashors1
Copy link
Contributor

@ashors1 ashors1 commented Jun 8, 2024

No description provided.

@ashors1 ashors1 requested a review from terrykong June 10, 2024 16:13
terrykong
terrykong approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, pax tests are expected:

  1. 16DP1FSDP1TP1PP_TE
  2. 1DP2FSDP4TP1PP_single_process_TE
  3. 2DP1FSDP2TP4PP
  4. 8DP1FSDP1TP1PP_eval_TE
  5. 8DP1FSDP1TP1PP_single_process_TE

2,4,5 are known single process failures and 1,3 are expected multinode failures

@ashors1 ashors1 merged commit bcb7205 into main Jun 11, 2024
153 of 164 checks passed
@ashors1 ashors1 deleted the pax-grok-patch branch June 11, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashors1 @terrykong