Dockerfile.jax: install JAX for TE build #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
commented
Aug 14, 2024
olupton
force-pushed
the
olupton/fix-te
branch
from
0a96759
to
1aa66ec
Compare
|
It looks good, thanks for figuring out the symlinks solution! The only suggestion is that could we have a separate script to create the link farm for all the necessary libraries? (Even in |
DwarKapex
requested review from
yhtang,
gpupuck,
terrykong,
CliveUnger,
nouiz and
DwarKapex
DwarKapex
approved these changes
Aug 19, 2024
gpupuck
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVIDIA/TransformerEngine#946 made TE's build process expect to be able to
import jax.