call #268
Open
call #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiemingz <jiemingz@nvidia.com>
Signed-off-by: jiemingz <jiemingz@nvidia.com>
Signed-off-by: jiemingz <=>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: jiemingz <=>
Signed-off-by: jiemingz <=>
Signed-off-by: jiemingz <=>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: jiemingz <=>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
…conversion (#238) Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
* Updates microbatch APIs to use megatron's instead of apex's Signed-off-by: Terry Kong <terryk@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * take off protected prefix Signed-off-by: Terry Kong <terryk@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
* Points to the documentation to the 0.4 branch * update documentation to point to nemo docs Signed-off-by: Terry Kong <terryk@nvidia.com> --------- Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
* Revert "add pref" This reverts commit 7dddeef. Signed-off-by: Terry Kong <terryk@nvidia.com> * Revert "update docs" This reverts commit 3d0a650. Signed-off-by: Terry Kong <terryk@nvidia.com> * revert steerlm2 docs Signed-off-by: Terry Kong <terryk@nvidia.com> * revert rpo/ipo docs Signed-off-by: Terry Kong <terryk@nvidia.com> * revert trtllm doc change on frontpage Signed-off-by: Terry Kong <terryk@nvidia.com> * Update CHANGELOG.md to 0.4.0 Signed-off-by: Terry Kong <terryk@nvidia.com> * remove aview(-1) Signed-off-by: Terry Kong <terryk@nvidia.com> * Addressing #260 (comment) Signed-off-by: Terry Kong <terryk@nvidia.com> * apply next batch of suggestions Signed-off-by: Terry Kong <terryk@nvidia.com> * applied suggestions in #260 (comment) Signed-off-by: Terry Kong <terryk@nvidia.com> * appliying suggestions in #260 (comment) Signed-off-by: Terry Kong <terryk@nvidia.com> * Update dpo.rst Provided copyedits on file. Signed-off-by: Terry Kong <terryk@nvidia.com> * Update index.rst Added copyedits to the file. Signed-off-by: Terry Kong <terryk@nvidia.com> * Update rlhf.rst Copyedited the file. Signed-off-by: Terry Kong <terryk@nvidia.com> * one space Signed-off-by: Terry Kong <terryk@nvidia.com> * revert steerlm2 deletion Signed-off-by: Terry Kong <terryk@nvidia.com> * restore rpo changes Signed-off-by: Terry Kong <terryk@nvidia.com> * restore missing regression comment Signed-off-by: Terry Kong <terryk@nvidia.com> * restore trtllm changeswq Signed-off-by: Terry Kong <terryk@nvidia.com> * restore sterrlm2 in index.rst Signed-off-by: Terry Kong <terryk@nvidia.com> * restore lost spacing Signed-off-by: Terry Kong <terryk@nvidia.com> --------- Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Which was introduced in this mcore commit: NVIDIA/Megatron-LM@32002bb Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong
force-pushed
the
dev
branch
2 times, most recently
from
327ef4a
to
978e209
Compare
terrykong
force-pushed
the
dev
branch
2 times, most recently
from
1a77f9f
to
962549c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
call train prep so the micro batches are calculated properly